Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove httpretty as a test dep #403

Merged
merged 3 commits into from
Oct 12, 2013
Merged

Remove httpretty as a test dep #403

merged 3 commits into from
Oct 12, 2013

Conversation

jamesls
Copy link
Member

@jamesls jamesls commented Oct 11, 2013

Instead we patch things out at the botocore level,
specifically botocore.endpoint.Endpoint.make_request.

@jamesls
Pull etag from parsed response, not http headers
e29a9ea 
This was working around a botocore bug, but it's now fixed
in botocore so this workaround isn't needed.
@jamesls
Remove httpretty as a test dep
e24a106 
Instead we patch things out at the botocore level,
specifically botocore.endpoint.Endpoint.make_request.
@jamesls
Remove unused imports
9b59102
@garnaat
Copy link
Contributor

garnaat commented Oct 12, 2013

LGTM

@toastdriven
Copy link
Contributor

🚢 it!

@jamesls jamesls merged commit 9b59102 into aws:develop Oct 12, 2013
@jamesls jamesls deleted the no-httpretty branch June 23, 2014 18:28
@CMCDragonkai CMCDragonkai mentioned this pull request Nov 14, 2022
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesls @garnaat @toastdriven